Api: WaiveWork Drivers: Don't Send SMS Updates

zolihonig commented 6 years ago

Don't send any SMS updates to WaiveWork drivers.

kristopolous commented 6 years ago

@zolihonig: Do you truly mean none? I've already audited a list and removed the relevant ones.

zolihonig commented 6 years ago

Not none, but I’d be curious to see the list

kristopolous commented 6 years ago

There's no central point ... let me see if I can get them all: Relevant ride flow: Both get:

Hi There! Your WaiveCar reservation with ${ car.license } has been confirmed. You'll have 15 minutes to get to your WaiveCar before your reservation expires. Let us know if you have any questions
Hi, you're WaiveCar is getting dangerously low on charge! If it runs out of juice, we'll have to tow it at your expense! Please call us at this number and we'll direct you to the nearest charger.
Hi, you're WaiveCar is getting really low. Please call us and we can help you get to a charger.
The reservation time for ${car.info()} is almost up! You can add an extra 10 minutes to get to the car for $1.00 by responding "SAVE" to this message.
Your reservation extension time has started! You have ${ config.booking.timers.extension.value } minutes more to get to ${ car.info() }.
Your WaiveCar reservation has been cancelled.
Your WaiveCar reservation has been extended 10 minutes.

Only non-waivework get:

Hi, we notice you haven't started the car. Feel free to call us if you are having troubles.
Hey! Just a heads up, you have 30 more free minutes in your WaiveCar reservation. After that, we charge $5.99 per hour. As a reminder, please return your WaiveCar to our return zone, and try to leave it at a charger. You can find both in our app. Thanks!
Hey there! Your free 2 hour WaiveCar rental has expired. Additional hours are billed at $5.99 per hour until you end your rental in the WaiveCar app.
Hi, it looks like you haven't started driving yet. Please start in the next 5 minutes or we'll have to end your booking and make the car available for other users. Please call us if there's difficulty
Hi, sorry you couldn't make it to your car on time. Your ${ timeWindow } minutes have expired and we've had to cancel your reservation for ${ car.info() }
Thanks for renting with WaiveCar! Your rental is complete. You can see your trip summary in the app.
Your WaiveCar rental has started! The first 2 hours are completely FREE! After that, it's $5.99 / hour. Make sure to return the car to ${ base }, don't drain the battery under 25mi, and keep within our driving borders to avoid any charges. Thanks for renting with WaiveCar!

Only waivework gets:

kristopolous commented 6 years ago

This is currently an assertion based on what I see in the code ... I haven't extensively confirmed this.

kristopolous commented 6 years ago

I really prefer to do this in a piecemeal fashion message by message ... I'm going to have to reject the implementation as proposed in the branch

WaiveCar / Waivecar