Closed julianstirling closed 6 months ago
FYI I added the requirement for the changes to be reviewed and approved.
@julianstirling Please also remove devices.json.old
since I was just keeping that in case I needed to revert during the update. I also made an inline suggestion that corrects a spelling mistake that I made in the markdown. Other than that it should be ready to merge.
Thanks @jmwright. I think with the new review rules you need to select the approve option in the review tab
@jmwright This is a rebase of your branch but rebased on top of the new changes in master. I pushed to a new branch as I thought it rude to force-push over your branch in case I break some work in progress.
On rebasing I
example-run.py
as it is based on the old orchestration. I know this killed your hashing code, see issue on hashing.generate.py
so it works with the newdevices.json
Are you happy for this to be merged? Or do you want to rebase differently, or carry on your draft in another way?