Wakoma / nimble

The nimble. An open source, rapidly deployable, wireless mesh network.
CERN Open Hardware Licence Version 2 - Strongly Reciprocal
66 stars 10 forks source link

Devices json update rebased #55

Closed julianstirling closed 6 months ago

julianstirling commented 6 months ago

@jmwright This is a rebase of your branch but rebased on top of the new changes in master. I pushed to a new branch as I thought it rude to force-push over your branch in case I break some work in progress.

On rebasing I

Are you happy for this to be merged? Or do you want to rebase differently, or carry on your draft in another way?

julianstirling commented 6 months ago

FYI I added the requirement for the changes to be reviewed and approved.

jmwright commented 6 months ago

@julianstirling Please also remove devices.json.old since I was just keeping that in case I needed to revert during the update. I also made an inline suggestion that corrects a spelling mistake that I made in the markdown. Other than that it should be ready to merge.

julianstirling commented 6 months ago

Thanks @jmwright. I think with the new review rules you need to select the approve option in the review tab