search

Wakoma / nimble

The nimble. An open source, rapidly deployable, wireless mesh network.
CERN Open Hardware Licence Version 2 - Strongly Reciprocal
66 stars 10 forks source link

Gets Baseline Test Working With Current State of Codebase #91

Closed jmwright closed 3 months ago

jmwright commented 3 months ago

This is done in preparation for moving to assembly CAD and rendering.

jmwright commented 3 months ago

@julianstirling I'll work on fixing the pylint errors in the shelf.py module.

julianstirling commented 3 months ago

@julianstirling I'll work on fixing the pylint errors in the shelf.py module.

Thanks!

jmwright commented 3 months ago

@julianstirling Everything is green now, and the new test is running in CI. However, you may take issue with my removal of the TODO entry from the pylint RC file. I also fixed some other things even after pylint was passing to give us some breathing-room before dropping below the 9.75 score threshold. Commenting some of the Shelf methods that are not implemented yet to pass pylint is hacky, but I will be working on them next and so I am not too worried about it.

In the interest of doing smaller PRs that handle one thing at a time, I'll take this out of draft so that it can be fully reviewed. Once we iterate and it is merged, I'll move on to assemblies and renders.

julianstirling commented 3 months ago

I am wondering if rather than commenting out the currently unfinished functions to make pylint happen we instead add:

 #pylint: disable=unused-argument

into the functions just before the return NotImplemented

This will silence the error but let us have the methods in place ready?

julianstirling commented 3 months ago

I'm happy with pulling the TODOs out of the RC file.

jmwright commented 3 months ago

I am wondering if rather than commenting out the currently unfinished functions to make pylint happen we instead add:

 #pylint: disable=unused-argument

into the functions just before the return NotImplemented

This will silence the error but let us have the methods in place ready?

Ok, that has been implemented in the latest commit.