Wakoma / nimble

The nimble. An open source, rapidly deployable, wireless mesh network.
CERN Open Hardware Licence Version 2 - Strongly Reciprocal
66 stars 10 forks source link

Add Shelf-Device Assembly and Rendering #92

Closed jmwright closed 2 months ago

jmwright commented 3 months ago

@julianstirling Where does (or should) the screw location information live? At a minimum I need a location and an axis for each screw. The axis could be something like +Y and -Y so that I can have the correct orientation of the screw relative to the hole it's going into.

julianstirling commented 3 months ago

@jmwright The problem with the text CI is that when pip installed without -e the devices.json is not in the expected location, we can either try to fix this or just add -e to the test yaml

jmwright commented 3 months ago

@jmwright The problem with the text CI is that when pip installed without -e the devices.json is not in the expected location, we can either try to fix this or just add -e to the test yaml

Thanks @julianstirling , I was wasting too much time not understanding that.

julianstirling commented 3 months ago

We probably want to add a try-except around the devices file reading that gives a more meaninful error if not installed with -e

jmwright commented 3 months ago

We probably want to add a try-except around the devices file reading that gives a more meaninful error if not installed with -e

@julianstirling Are you suggesting that should be part of this PR?

jmwright commented 2 months ago

Here are two samples of the shelf assembly rendering at work. One is the default with full color, the second is with a configurable black-and-white "theme" that is more in line with traditional annotated drawings. I left the automated assembly lines in place for both, and I left the assembly exploded. I'm a little disappointed in how the CAD kernel renders some edges, especially in the black-and-white version, but I think it's passable.

assembly_render_test_exploded_color

assembly_render_test_exploded_black_and_white

jmwright commented 2 months ago

@julianstirling I have marked this as ready for review.