[Bug]: Towers of the same variant have the same Fabric Waystone name

[Prymz]

Is there an existing issue for this?

• [X] I have searched the existing issues

Description

Each tower variant has the same name for its Fabric Waystone: Derelict Towers are always named: Boyadawa Grassy Derelict Towers are always named: Pozijuma Regular Towers are always named: Cizumiqa Jungle Towers are always named: Havirahi Icy Towers are always named: Zazogura Ocean Towers are always named: Yosugama Warm Ocean Towers are always named: Buveciga

To Reproduce

Load world with Towers of the Wild: Reworked [Fabric Waystones] v4.0.1 /locate or /place 2 of any same tower structure variant

Expected behavior

Fabric Waystone names should be randomized as they are generated in villages or when placed manually in the world.

Mod Version

v4.0.1

Mod Variation

Datapack - Fabric Waystones

Minecraft Version

1.19

Java Version

Java 17

Fabric Version (only if below v3.0.0)

Fabric Loader: v0.14.8 Fabric API: v0.58.0+1.19

Relevant log output

No response

Anything else?

No response

[xPand4B]

Many thanks for reporting this and also listing the names for each variant! ❤️ I just started looking why this is, but I'm not home till sunday.

Will keep you updated tho! 💪

[xPand4B]

And because you wrote at curseforge that it could be at your end, sadly, this isn't the case, just confirmed the issue :/

[xPand4B]

And also just found a floating shipwreck...so at least I'm not the only one introducing bugs xD

[Prymz]

Thanks for looking into it! When I first noticed it, I was using additional datapacks including a world gen one, but did an isolated test before posting the issue to confirm it occurred in default vanilla generation.

[Prymz]

And about the floating shipwreck... I've noticed Minecraft doesn't seem to do a good job testing if structures fit into the terrain, like with villages decapitated by mountains or caves.

[xPand4B]

Off-topic: With this attitude you would be a great QA tester in general

[Prymz]

Thanks! If there is anything I can do, I'd like to get involved!

[Prymz]

I am very sorry if I am overstepping, but I wanted to try to make your job easier especially since you are not home.

I was curious how the Wraith's fabric waystones mod did their village structures for random waystone names so I opened the structure file in NBTExplorer how the waystone was encoded. I then compared this to the regular fabric_waystone_tower_top structure file. The tower structures have more data stored their the waystone blocks. I deleted the tags not present in the village waystone structure and that seemed to fix it; the waystone names were random for all the structures that I changed.

[xPand4B]

Great job! Many thanks! ♥️That's the issue.

I remember something similar happened to the other waystones mod that is supported.

The whole topic is kinda tricky, because the stuff you just removed is auto generated if you're editing the structure inside Minecraft...

Sorry for the inconveniences, I'll commit and release the fix once I'm back home.

[Prymz]

No inconveniences! Thank you for being so responsive and receptive!

[xPand4B]

@Prymz I just updated everything and created the .zip archive. Would be great if you would do a small check on your side if everything's working as expected.

Towers_Of_The_Wild_Reworked_v4.0.2_Fabric_Waystones.zip

Edit: If you like to also get further updates feel free to :)

[Prymz]

It looks good. I did not encounter any repeated names. Thank you!

[xPand4B]

@Prymz The fix has been released on this Repo and Curseforge as well (Curse might take a bit to appear because they have am approval process after uploading a new version).

Again, many thanks for your contribution! 🚀