Wall-Brew-Co / brew-bot

A quick, dirty way to get randomized beer recipes
https://brewbot.wallbrew.com/
MIT License
11 stars 4 forks source link

Migrate recipe generation and calculations fns to .cljc #12

Closed nnichols closed 4 years ago

nnichols commented 5 years ago

Is your feature request related to a problem? Please describe. N/A

Describe the solution you'd like Currently, all code is bundled as .cljs files, which is great for working on the UI; however, it locks the code in somewhat. If this code was migrated to .cljc, the core functionality of brew-bot could be deployed to clojars for others to use while still making it accessible to the UI.

Describe alternatives you've considered The alternative is creating a separate repository, deploying that, and including it as a dependency here; however, since the UI is tightly coupled to that code, it doesn't make much sense.

Additional context This is a nice-to-have that may lead into config hell.

nnichols commented 4 years ago

Fixed by: https://github.com/nnichols/brew-bot/pull/16