search

WallStreetAnalytics / wallstreetanalytics

An endeavor to create an analytics tool to democratize the information hedge funds are creating teams to collect.
813 stars 30 forks source link

API Gateway #37

Open ibreakifix opened 3 years ago

ibreakifix commented 3 years ago

I wanted to contribute some code I started on a couple weeks ago. I was working on my own stock dashboard, but I've only got a functional API gateway so far. The front end and gateway were going to be in PHP, and I was planning on some calculation functionality in another language.

The end goal is to gather data, store it in a db, then create a dashboard where the user can run calculations, monitor real time market data, create screeners, and view various social media / news data. I'll continue to develop this project as time allows, but depending on the response, I may or may not push it to the public repo

zoox101 commented 3 years ago

This may be a good fit for this project, but I am having trouble sorting through all the files. I am not very familiar with PHP. Did you commit some external libraries or did you write all these 1034 files?

notjoshjames commented 3 years ago

This is clearly the largest PR we have. PHP is not my native language but I'm subbing to watch this.

satalaondrej commented 3 years ago

After just a few glances, i think there are quite a lof of problems. For one, there seem to be included files from external libraries. I would advice to use something more "off the shelf". This code doesnt make sense (at least from my point of view) in its current state.

ibreakifix commented 3 years ago

This may be a good fit for this project, but I am having trouble sorting through all the files. I am not very familiar with PHP. Did you commit some external libraries or did you write all these 1034 files?

Yeah there's a few libraries all are in includes/vendor/ folder. These don't need to be in the repo and can be installed with composer, but I left them because I had to make some modifications to the polygon.io library to get it to work.

Essentially, the only libraries in use, other than what polygon's client requires are twig for tempting (not used currently, as there's no front end), and Guzzle for sending http requests. You could even get rid of guzzle, but making async requests with curl in PHP is kind of a pain.

itsclaireh commented 3 years ago

@ibreakifix Are you in the discord? We established some SMEs regarding code and are in the process of setting contribution guidelines, and it would appropriate now to reach out to an admin to discuss what to do with this!

https://discord.gg/YqBBJ6jnCD (this link shouldn't expire)