search

Wallacoloo / printipi

3d printing directly through the Raspberry Pi's GPIO pins
MIT License
141 stars 43 forks source link

AxisStepper refactoring #78

Closed Wallacoloo closed 9 years ago

Wallacoloo commented 9 years ago

Some slight modifications to the AxisStepper interface would be beneficial:

Linear and Arc- AxisSteppers should be merged into one uniform type that handles both types of movement. AxisSteppers should not be re-initialized and copied, rather call AxisStepper::startLine or ::startArc at the beginning of a move.

Now that they don't have to be re-initialized, AxisSteppers can be properly initialized by the CoordMap, which means no more need to template by AxisIdx (can be provided by the CoordMap during construction).

Wallacoloo commented 9 years ago

The types have now been merged, but still need to refactor the initializations.

Wallacoloo commented 9 years ago

Everything suggested in the original post has now been implemented (I neglected to tag this issue in some of the commits), so closing this issue. I suspect AxisSteppers will be refactored more in the future, but this is a good start.