Closed Wallacoloo closed 9 years ago
The types have now been merged, but still need to refactor the initializations.
Everything suggested in the original post has now been implemented (I neglected to tag this issue in some of the commits), so closing this issue. I suspect AxisSteppers will be refactored more in the future, but this is a good start.
Some slight modifications to the AxisStepper interface would be beneficial:
Linear and Arc- AxisSteppers should be merged into one uniform type that handles both types of movement. AxisSteppers should not be re-initialized and copied, rather call AxisStepper::startLine or ::startArc at the beginning of a move.
Now that they don't have to be re-initialized, AxisSteppers can be properly initialized by the CoordMap, which means no more need to template by AxisIdx (can be provided by the CoordMap during construction).