Open rachelblasucci opened 6 years ago
I think I had leftover files from the last time I tested the kafka bits. Number 3 isn't an issue. :-)
@rachelblasucci Re: bullet 1, the Running Celsius Kafka
(https://github.com/WallarooLabs/wallaroo/tree/release-0.5.2/examples/python/celsius-kafka#running-celsius-kafka) instructs folks that all shells should be opened and then they should change to the examples/python/celsius-kafka
directory. Do you think the additional note regarding changing the directory for shell 3 is also necessary?
Ah, yes, good point. I was running with Docker in this case.. So, I might consider clarifying the comment, somehow, as part of the previous statement:
NOTE: If running in Docker, the kafkfa cluster and kafkacat should be run from your host and not within the Docker container.
Or maybe just stating where it's really necessary to be in the correct folder?
@enilsen16 Would love feedback on this one, too. :)
item 2 is resolved by https://github.com/WallarooLabs/wallaroo/issues/2368
item 1 is not going to be part of 0.5.2 as there's no quick/easy way to make the README clear for both wallaroo in docker and wallaroo outside of docker users. This will have to be addressed separately after the release.
@enilsen16 @SeanTAllen Is this/Can the rest of this be addressed as part of the book changes coming up?
No. book changes would be purely organization, no content changes.
1) Small thing, but it would be useful for the
README
from thecelsius-kafka
application to mention switching directories in theShell 3
step.Specifically, something like:
instead of only:
2) With
Shell 2
: The sentence, "Set up a listener to monitor the Kafka topic to which you would the application to publish results." should be rephrased.3) For me, both this time and last release, running the
./cluster up 1
didn't start uplocal_kafka_1_1
. Re-running the command worked. Perhaps mention this could happen?2359