WalletConnect / WalletConnectKotlinV2

WalletConnect Kotlin SDK v2
Apache License 2.0
253 stars 85 forks source link

NoSuchMethodError when open Web3Modal #1299

Open xemniz opened 9 months ago

xemniz commented 9 months ago

Describe the bug I have this error when trying to open modal sheet java.lang.NoSuchMethodError: No virtual method getBackQueue()Lkotlin/collections/ArrayDeque; in class Landroidx/navigation/NavController; or its super classes (declaration of 'androidx.navigation.NavController' appears in /data/app/~~EhdRHUGllLoB-BzAZgrPjQ==/io.interfacelab.debug-m78d9nwRSf09VvJSFTG06Q==/base.apk!classes18.dex) at com.walletconnect.web3.modal.ui.components.internal.root.Web3ModalRootState.getCanPopUp(Web3ModalRootState.kt:32) at com.walletconnect.web3.modal.ui.components.internal.root.Web3ModalRootKt.TopBarStartIcon(Web3ModalRoot.kt:105) at com.walletconnect.web3.modal.ui.components.internal.root.Web3ModalRootKt.access$TopBarStartIcon(Web3ModalRoot.kt:1)

SDK Version

To Reproduce Steps to reproduce the behavior: navController.openWeb3Modal( shouldOpenChooseNetwork = true, onError = { } )

Expected behavior Doesn't crash

Device (please complete the following information):

kacperoak commented 9 months ago

What version of navigation dependencies do you have in your project?

xemniz commented 9 months ago

2.7.6

Raenar4k commented 9 months ago

Same issue. Version bom 1.22.0 We don't even have navigation dependency declared. I've used Web3ModalComponent:

    Web3ModalComponent(
        shouldOpenChooseNetwork = true,
        closeModal = { }
    )

This happens because other library also uses navigation library, but uses more modern version, which is then applied to web3modal:

+--- com.walletconnect:web3modal -> 1.1.1
|    +--- androidx.navigation:navigation-fragment-ktx:2.5.3 -> 2.7.6

@kacperoak Is it possible for Wallet Connect to update navigation library version? I think its reasonable thing to do. Version 2.5.3 was realeased on October 24, 2022.

Raenar4k commented 8 months ago

@jakubuid Hi. Any update on that? As this is blocker for us - we are still using handmade UI + Sign SDK for this, and cannot begin migration to Modal SDK until this is resolved

jakubuid commented 2 months ago

@Raenar4k Hello, I'll work on the update of navigation lib version

jakubuid commented 2 months ago

@Raenar4k the androidx.navigation:navigation-fragment-ktx is already on 2.7.7 within the newest SDK version. I'll update it further to 2.8.0 tho