WalletConnect / WalletConnectModalFlutter

The WalletConnectModal for WalletConnect built using Flutter.
https://pub.dev/packages/walletconnect_modal_flutter
Apache License 2.0
30 stars 19 forks source link

example app build is broken on latest Flutter stable #18

Open Sameerkash opened 1 year ago

Sameerkash commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

In the example project, the package fl_toast seems to be conflicting with the latest flutter version since it uses parameters that have been removed from the Flutter SDK.

specifically, primaryVariant and secondaryVariant of the ColorScheme theme class.

fluttertoast: ^8.2.2

To Reproduce Steps to reproduce the behavior:

  1. Upgrade to the latest version of Flutter 3.13 and run the app.
  2. Build fails specifying the error,

Expected behavior Build success and flutter app launches.

Screenshots

../../../../.pub-cache/hosted/pub.dev/fl_toast-3.1.0/lib/src/toasts.dart:324:9: Error: No named parameter with the name 'primaryVariant'.
        primaryVariant: colorScheme.onPrimary,
        ^^^^^^^^^^^^^^
../../../../Documents/Development/flutter/packages/flutter/lib/src/material/color_scheme.dart:87:9: Context: Found this candidate, but the arguments don't match.
  const ColorScheme({
        ^^^^^^^^^^^
Target kernel_snapshot failed: Exception

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Commenting the broken code in the library fixes the problem.

Ideally fluttertoast: ^8.2.2 should be used instead of fl_toast since it has not been actively maintained for over 2 years.

Sameerkash commented 1 year ago

Would be happy to help with the migration.

Sameerkash commented 1 year ago

@Luzzotica Please let me know if migrating sounds good 😄

Luzzotica commented 1 year ago

Hold off for a bit.

I have a pretty massive update for the example app coming in later today.

Sameerkash commented 1 year ago

Cool, let me know if you need any help !

TesslaRay commented 1 year ago

Thanks for the example uploaded these days. For now, the connection is working perfectly. 🥳