search

WalletConnect / WalletConnectSharp

A C# implementation of the WalletConnect client
Apache License 2.0
139 stars 60 forks source link

default session saving completed & tested #156

Closed gigajuwels closed 5 months ago

skibitsky commented 7 months ago

There is another issue that can break session requests.

Engine now uses OrderedKeys field when making requests: https://github.com/WalletConnect/WalletConnectSharp/blob/feat/default-session-saving/WalletConnectSharp.Sign/Engine.cs#L687

The problem I'm sometimes facing is that RequiredNamespace object can have one Key, but no OrderedKeys. Perhaps there is a scenario when dictionary is assigned directly, bypassing the Add method of RequiredNamespaces.

skibitsky commented 6 months ago

@gigajuwels the TestAddressProviderDefaultsSaving test fails

skibitsky commented 5 months ago

Well done, @gigajuwels!