search

WalletConnect / WalletConnectUnity

[DEPRECATED] WalletConnect v2 and Modal for Unity 🎮
MIT License
152 stars 49 forks source link

DisconnectAsync method doesn't complete when there is no internet connection #201

Closed astasovsky closed 7 months ago

astasovsky commented 7 months ago

Describe the bug WalletConnect.Instance.DisconnectAsync method doesn't complete when there is no internet connection

To Reproduce Steps to reproduce the behavior:

  1. Open app
  2. Connect crypto wallet
  3. Turn off the Internet
  4. Disconnect crypto wallet
  5. See that nothing happens (async operation is not completed or TimeoutException is not thrown)
  6. Turn on the Internet
  7. See that async operation is not completed or TimeoutException is not thrown

Expected behavior DisconnectAsync method should send TimeoutException or complete

Environment

Is this happening in Unity Editor or on a player like Android, iOS, Windows? This is happening in Unity Editor and on Android. It hasn't been tested in iOS and Widows.

Wallets used for testing Metamask Android, Trust Wallet Android

skibitsky commented 7 months ago

Fixed in WalletConnectUnity Modal v1.1.3