search

WalletConnect / WalletConnectUnity

[DEPRECATED] WalletConnect v2 and Modal for Unity 🎮
MIT License
152 stars 49 forks source link

Vision Pro Unity Support #223

Closed Biso240 closed 6 months ago

Biso240 commented 6 months ago

hi, I would like to ask if it is possible to make a version also for the vision pro as Unity modal does not work for it at the moment. A thousand thanks

skibitsky commented 6 months ago

Hello,

What exactly isn't working?

Biso240 commented 6 months ago

When I try to build for visionOS(Windowed Mode), the unity compiler give me this errors(I'm logged because in the editor works):

Screenshot 2024-04-30 alle 2 48 34 PM
skibitsky commented 6 months ago
  1. Did you install packages through OpenUPM or directly from git?
  2. If you installed directly from git, do you also have com.walletconnect.core installed?
  3. Are you encountering similar errors when the target platform is iOS?
  4. What version of Unity are you using?
skibitsky commented 6 months ago

Unable to reproduce with Unity 2022.3.18. I don't get the errors. Screenshot 2024-04-30@2x

Biso240 commented 6 months ago

I tried from git and also from OpenUPM. For iOS it works, but for VisionOs no. I have the 2022.3.24f1 version and I will try with your version

Biso240 commented 6 months ago

also with your unity version doesn't work :(

Biso240 commented 6 months ago

if I build in this way: like an IpadOS app, it works

Screenshot 2024-04-30 alle 7 35 42 PM
skibitsky commented 6 months ago

Does it work for you in the Editor with VisionOS as the target platform?

skibitsky commented 6 months ago

I was able to reproduce it. It happens when building for VisionOS.

skibitsky commented 6 months ago

Temporary workaround

@Biso240 let me know if that helps. I'll include visionOS in the next release.

skibitsky commented 6 months ago

@Biso240, could you please test this PR? I also fixed the UI layout setting; it will now use wallet deep link by default , similar to how it works on mobile.

https://github.com/WalletConnect/WalletConnectUnity/pull/225

Biso240 commented 6 months ago

Ok I can now build for VisionOs and build it into Vision Pro. After I got the same issue that you can find it also in IOS and Android. https://github.com/WalletConnect/WalletConnectUnity/issues/224

skibitsky commented 6 months ago

Nice, I'm working on #224, but it shouldn't block you from development. I'll try to release a fix next week.