WalletConnect / WalletConnectUnity

[DEPRECATED] WalletConnect v2 and Modal for Unity 🎮
MIT License
152 stars 49 forks source link

Installation progress is broken via github. Nethereum has wrong package name. #240

Closed QuipHop closed 3 months ago

QuipHop commented 3 months ago

Describe the bug It's impossible to install WalletConnectUnity via github, Nethereum package is missed. con.walletconnect.nethereum should be com.walletconnect.nethereum ?

To Reproduce Steps to reproduce the behavior:

  1. Follow README and try to install via github.
  2. Stuck with a lot of messed packages.

Expected behavior Installation progress should be clear with correct dependencies Screenshots

Environment

Is this happening in Unity Editor or on a player like Android, iOS, Windows?

Wallets used for testing Metamask

Additional context Add any other context about the problem here.

skibitsky commented 3 months ago

Hello @QuipHop,

Did you follow Install via Package Manager with Git URL? The Nethereum package is optional and shouldn't be breaking the installation of Core and Modal packages.

QuipHop commented 3 months ago

Hello @QuipHop,

Did you follow Install via Package Manager with Git URL? The Nethereum package is optional and shouldn't be breaking the installation of Core and Modal packages.

Yes. The problem is you can't clone the repo or even download and unarchive zip without renaming deps. Nethereum package is actually required for my Unity project. I bet that at least typo in the package name should be fixed.

QuipHop commented 3 months ago

Tried to reinstall everything within OpenUPM, got missed Nethereum refs. Then tried to install Nethereum using Package Manager -> Add package by name -> com.walletconnect.nethereum

Got Error: [Package Manager Window] Error adding package: com.walletconnect.nethereum. Unable to add package [com.walletconnect.nethereum]: Package com.walletconnect.nethereum@1.0.1 has invalid dependencies or related test packages: com.nethereum.unity (dependency): Package [com.nethereum.unity@4.19.1] cannot be found

skibitsky commented 3 months ago

Thank you, I will look into git installation issue 🙏

As for OpenUPM, the easiest approach is to use openupm-cli to install all packages including com.walletconnect.nethereum. The com.walletconnect.nethereum depends on official com.nethereum.unity which has a different scope (com.nethereum). The CLI tool adds all necessary scopes into the project manifest automatically. You can also do it manually.

skibitsky commented 3 months ago

The git installation issue was caused by the order in which packages were installed. It's important to follow a specific order to avoid compile errors that prevent subsequent package installations. I'll update the documentation to clarify this. Thanks for flagging it, @QuipHop 🙏

You may also be interested in our AppKit solution for Unity, it has more features and Nethereum integration. There's a feature comparison table here.

QuipHop commented 3 months ago

Got it, thank you @skibitsky