search

WalletConnect / a2

An Asynchronous Apple Push Notification (apns2) Client for Rust
MIT License
136 stars 47 forks source link

Fix stack overflow in Error's Display impl #47

Closed AzureMarker closed 3 years ago

AzureMarker commented 3 years ago

Also removed some deprecated impls and changed the "reason" message from the debug string to the human-readable message.

Fixes #46

pimeys commented 3 years ago

I'd actually like to see some modern error crate here instead. Could you try implementing the Error with thiserror?

AzureMarker commented 3 years ago

Sure, I can do that, though it will do the same thing with more dependencies (thiserror just implements the std error, and this error is simple enough that it's not a huge benefit).

dbrgn commented 3 years ago

thiserror does more than just implementing std error, it also creates automatic From impls, among other things.

AzureMarker commented 3 years ago

Are you talking about making more functional changes to the error then? I'm not sure what scope you have in mind for these changes (i.e. breaking changes?).

pimeys commented 3 years ago

Ok, xmas holidays and some time for my old crates. This looks solid, merging. Thank you.