search

WalletConnect / a2

An Asynchronous Apple Push Notification (apns2) Client for Rust
MIT License
136 stars 47 forks source link

Upgrade to `base64 0.13`. #56

Closed rneswold closed 2 years ago

rneswold commented 2 years ago

This commit updates the project to use v0.13 of the base64 crate, which is what hyper is using. By upgrading, we don't link in two versions of base64.

rneswold commented 2 years ago

Is there a reason to not merge this pull?

pimeys commented 2 years ago

Is there a reason to not merge this pull?

Sorry. The only reasons being me not really using this crate anymore and having tons of work that distracts me from the old crates. Merging and doing a new release now.

rneswold commented 2 years ago

Is there a reason to not merge this pull?

Sorry. The only reasons being me not really using this crate anymore and having tons of work that distracts me from the old crates. Merging and doing a new release now.

No problem. I just wanted to make sure I wasn't holding up the merge. I understand now this is a lower priority project for you.

(I use cargo tree -d when building Rust binaries to make sure I'm not compiling and linking duplicate libraries. a2 was the only crate in my project that was adding a duplicate, so thanks for merging this.)

pimeys commented 2 years ago

Yeah, I'm quite pedantic on that too... Thanks for the pr.