WalletConnect / a2

An Asynchronous Apple Push Notification (apns2) Client for Rust
MIT License
136 stars 47 forks source link

fix: Add tcp feature to hyper #77

Closed threema-donat closed 2 months ago

threema-donat commented 2 months ago

Prevents executor must be set panic when hyper with tcp enabled is not already in the dependencies of the project.

Description

I suggest to release a new version once this is merged since a2 cannot work for anybody not having hyper ^0.14 with tcp feat enabled in the dependencies.

Resolves #76

How Has This Been Tested?

Used this as a path dependency in this project

Due Dilligence

link2xt commented 2 months ago

Also hyper itself should be updated: https://github.com/WalletConnect/a2/pull/75

link2xt commented 2 months ago

cc @HarryET because they are not watching the repo

HarryET commented 2 months ago

cc @HarryET because they are not watching the repo

I'm no longer a member of the company so sadly my ability to merge the PR isn't there anymore. I'll ping someone there and see if they can review and/or take the repo back.

\cc @chris13524

chris13524 commented 2 months ago

Thanks for the ping @HarryET! This repo wasn't being watched but now it is.

@threema-donat can you rebase on #75 ?

threema-donat commented 2 months ago

I would suggest to merge this first and then do a release (e.g. as version 0.8.1) before merging #75 for two reasons:

threema-donat commented 2 months ago

@chris13524 Thank you for merging this! I realized that you have created the GitHub release for 0.8.1, but not published yet on crates.io.\ I guess you might have forgotten to publish it; would you be so kind and publish it?

chris13524 commented 2 months ago

Yeh @threema-donat yes sorry, working on the publish. Need to transfer from original owner