WalletConnect / blockchain-api

WalletConnect's Blockchain API
MIT License
51 stars 40 forks source link

feat(sessions): irn client scaffolding #681

Closed geekbrother closed 2 months ago

geekbrother commented 2 months ago

Description

This PR implements the IRN client abstraction into the blockchain-api. The following changes are made:

CI/CD and build

The following IRN client configuration parameters were added:

The following IRN client storage commands were added:

IRN client abstraction is bound to the irn global state to be accessible from handlers.

The record TTL is 30 days. (Which should be ok for sessions).

How Has This Been Tested?

Due Diligence

xDarksome commented 2 months ago

The record TTL is 90 days. (Which should be ok for sessions).

does it need to be 90 days? our current longest living data is 30 days

I'm talking from the perspective of data migrations, if our highest value is going to be 90 days, then next time we decide to do full migration we would need to shadow the data for 90 days to be sure

And it probably will happen in the next 3 month, as we will be transitioning to the permissioned network

geekbrother commented 2 months ago

The record TTL is 90 days. (Which should be ok for sessions).

does it need to be 90 days? our current longest living data is 30 days

I'm talking from the perspective of data migrations, if our highest value is going to be 90 days, then next time we decide to do full migration we would need to shadow the data for 90 days to be sure

And it probably will happen in the next 3 month, as we will be transitioning to the permissioned network

It decreased to 30 days. The context: slack.