WalletConnect / modal-react-native

Simplest and most minimal way to connect your users with WalletConnect
https://docs.walletconnect.com/2.0/advanced/walletconnectmodal/about?platform=react-native
Apache License 2.0
31 stars 9 forks source link

[bug]: #19

Closed bhsrampage closed 1 year ago

bhsrampage commented 1 year ago

Description

Under connection to metmask, popup doesnt show the app details for signing and transaction requests. It shows --> metamask.io in dev --> uniswap.org in prod versions

const providerMetadata = { name: 'NFTHodlr', description: 'Connect to NFTHodlr App', url: 'https://nfthodlr.xyz', icons: ['https://ibb.co/XVmwLS3'], redirect: { native: 'nfthodlr://', universal: 'http://app.nfthodlr.xyz/', }, };

Dev Screenshot_20230630-155039

Prod Screenshot_2023-06-30-15-50-15-800_io metamask

WalletConnect Modal SDK version

1.0.0-rc.3

Output of npx react-native info

info Fetching system and libraries information... System: OS: macOS 13.4.1 CPU: (8) arm64 Apple M1 Pro Memory: 79.69 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.2.0 path: /opt/homebrew/bin/node Yarn: version: 1.22.19 path: /opt/homebrew/bin/yarn npm: version: 9.6.6 path: /opt/homebrew/bin/npm Watchman: version: 2023.05.22.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.12.1 path: /usr/local/bin/pod SDKs: iOS SDK: Platforms:

info React Native v0.72.1 is now available (your project is running on v0.72.0). info Changelog: https://github.com/facebook/react-native/releases/tag/v0.72.1 info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.72.0 info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos&platform=android".

Expo Version (if applies)

No response

Steps to reproduce

Setup walletconnect modal with custom metadata. and sign message or transaction.

Snack, code example, screenshot, or link to a repository

none

ignaciosantise commented 1 year ago

hey @bhsrampage 👋 Each wallet decides how to show the metadata. In case of MetaMask, they show it only in the connection popup:

1
bhsrampage commented 1 year ago

With the v1 package i.e react-native-dapp it used to show up properly. In every tx signing popup.