WalletConnect / modal-react-native

Simplest and most minimal way to connect your users with WalletConnect
https://docs.walletconnect.com/2.0/advanced/walletconnectmodal/about?platform=react-native
Apache License 2.0
31 stars 9 forks source link

[bug]: `explorerExcludedWalletIds` excludes all #68

Closed sasicodes closed 1 year ago

sasicodes commented 1 year ago

Description

using explorerExcludedWalletIdsusing initialization excludes all wallets including explorerRecommendedWalletIds.

Experiencing this recently, before it was good, showed only explorerRecommendedWalletIds in both main modal and view all view.

WalletConnect Modal SDK version

1.0.0-rc.7

Output of npx react-native info

im using expo

Expo Version (if applies)

48.0.18

Steps to reproduce

<WalletConnectModal
            themeMode="dark"
            projectId={WC_PROJECT_ID}
            explorerExcludedWalletIds="ALL"
            providerMetadata={providerMetadata}
            explorerRecommendedWalletIds={explorerRecommendedWalletIds}
          />

Snack, code example, screenshot, or link to a repository

2023-08-05 at 21 40 56@2x 2023-08-05 at 21 41 10@2x
sasicodes commented 1 year ago

If I removed explorerExcludedWalletIds works, but i dont want ALL wallets in view all modal.

<WalletConnectModal
            themeMode="dark"
            projectId={WC_PROJECT_ID}
            // explorerExcludedWalletIds="ALL"
            providerMetadata={providerMetadata}
            explorerRecommendedWalletIds={explorerRecommendedWalletIds}
          />
2023-08-05 at 21 42 44@2x 2023-08-05 at 21 43 12@2x
ignaciosantise commented 1 year ago

@sasicodes thanks for reaching out!

You are right, I broke some cases in the latest release 🥲

I already created a PR to solve that, once it's merged i'll release a canary version for you to test it 💪

sasicodes commented 1 year ago

@sasicodes thanks for reaching out!

You are right, I broke some cases in the latest release 🥲

I already created a PR to solve that, once it's merged i'll release a canary version for you to test it 💪

amazing 🚀

ignaciosantise commented 1 year ago

@sasicodes @walletconnect/modal-react-native@1.0.0-rc.10 released 🎉 Can you check if it works with your case?

sasicodes commented 1 year ago

@sasicodes @walletconnect/modal-react-native@1.0.0-rc.10 released 🎉 Can you check if it works with your case?

yes, now explorerExcludedWalletIds="ALL" is working fine. Only defined wallets are shown 👍🏻

Thanks.