search

WalletConnect / modal-react-native

Simplest and most minimal way to connect your users with WalletConnect
https://docs.walletconnect.com/2.0/advanced/walletconnectmodal/about?platform=react-native
Apache License 2.0
31 stars 9 forks source link

WalletConnect v2 dose not work with 1inch Android wallet #74

Closed mohandesjiri closed 1 year ago

mohandesjiri commented 1 year ago

Describe the bug In my react-native application, I could connect to 1inch wallet without any trouble, but when trying to send the transaction with 1inch Android wallet, this error is printed in the console: 

[Error: Could not open URL 'oneinch://wc?requestId=REQUEST_ID&sessionTopic=SESSION_TOPIC': No Activity found to handle Intent { act=android.intent.action.VIEW dat=oneinch://wc?requestId=REQUEST_ID&sessionTopic=SESSION_TOPIC flg=0x10000000 }]

SDK Version (if relevant)

To Reproduce Steps to reproduce the behavior:

  1. Connect dApp to the 1inch Android wallet via Walletconnect v2 react-native
  2. Try to send a transaction via 1inch Android wallet
ignaciosantise commented 1 year ago

hey @mohandesjiri thanks for reaching out. Apparently 1inch wallet doesn't have the scheme oneinch added in their manifest file, and that's why the SDK is failing to open the app. We'll reach em to see if they can add it, or we'll think another solution

mohandesjiri commented 1 year ago

@ignaciosantise Thanks for the answer, But I'm curious how is it work for the connect step and break down for the send transaction?

ignaciosantise commented 1 year ago

@mohandesjiri i've checked the case and we have two issues:

  1. 1inch only supports a specific case of deeplinking -> We'll probably talk to them this week to fix it
  2. There's an uncovered case where the modal tries to use the deeplink for requests but should use the fallback method (universal-link)
ignaciosantise commented 1 year ago

Hey @mohandesjiri 👋 I've just released a new version of the modal that solves the issue