WalletConnect / modal

WalletConnectModal repository
https://lab-walletconnect-modal.pages.dev/
Apache License 2.0
18 stars 15 forks source link

[bug] Chain filtering not applied to wallets list #20

Open DamirSQA opened 1 year ago

DamirSQA commented 1 year ago

Link to minimal reproducible example

/

Summary

Greetings, @web3modal/standalone package is replaced In favour of @walletconnect/modal, and it seems that standaloneChains[chainId] property is changed to chains: [chainId]. Aside from the issue, is there a way to add only specific wallet(s)?

image

List of related npm package versions

2.5.9

xzilja commented 1 year ago

@DamirSQA you can add specific wallets via options https://docs.walletconnect.com/2.0/web/walletConnectModal/modal/options

DamirSQA commented 1 year ago

Hi @0xAsimetriq had a look, but it doesn't seem that it solves it for me. Regarding mentioned chanId issue, it worked fine in 2.4.7 and versions before.

xzilja commented 1 year ago

Filtering by chain id might be an actual bug, I need to look into this, but for your other question

Aside from the issue, is there a way to add only specific wallet(s)?

You can use options for explorer to filter out / only specify wallets you want. What issue are you facing there?

DamirSQA commented 1 year ago

Thanks, I've used enableExplorer: false for now, as there's only one mobile wallet to be displayed in this moment. However, I've noticed that If I add desktopWallets :[...], that wallet is present in modal as on the image, but that's not the case for mobileWallets: [...]. Though, I've checked it out in browser, not the actual device, but just to point it out, if it's something you'd like to have a look into as well. image

xzilja commented 1 year ago

What's displayed on mobile when you add it via mobileWallets?

mr-zwets commented 1 year ago

yeah the mobileWallets setting doesn't work for me either