WalletConnect / notify-server

notify.walletconnect.com
https://docs.walletconnect.com/web3inbox/about
MIT License
20 stars 6 forks source link

fix: only remove from mailbox after queued event #541

Closed chris13524 closed 6 months ago

chris13524 commented 6 months ago

Description

Fixes this issue raised by Ivan:

hey, regarding the queued -> accepted change in notify server that you made: there's a problem now with how the messages are removed using the irn_batchReceive where the message may not yet be in the mailbox when notify tries to remove it

Solution as suggested is to subscribe to both. When accepted is received, handle the message. And when queued is received, remove the message from the relay mailbox.

How Has This Been Tested?

Existing tests

Due Diligence