search

WalletConnect / walletconnect-example-dapp

Example Dapp
https://example.walletconnect.org/
MIT License
363 stars 346 forks source link

added support for older eip1271 implementations #63

Open poocart opened 3 years ago

poocart commented 3 years ago

Covers incompatibility between different versions of EIP1271 proposal.

Reference to EIP1271 history that this was in proposal and has been implemented by some wallets – https://github.com/ethereum/EIPs/commit/026675e59eacf773e081093c06155a2e924d2f7b#diff-5641e34a6f945196e79a576e6406eb4690ee5e34624ccedfcc8e42157e23bd06.

netlify[bot] commented 3 years ago

Deploy request for walletconnect-example pending review.

Review with commit 61335b586d2f691fcd98af299b7a7e2971bb3ed3

https://app.netlify.com/sites/walletconnect-example/deploys

poocart commented 3 years ago

This deployed at https://stupefied-hamilton-8cb366.netlify.app/

poocart commented 3 years ago

Updated PR description: added reference to EIP1271 history that this was in proposal and has been implemented by some wallets – https://github.com/ethereum/EIPs/commit/026675e59eacf773e081093c06155a2e924d2f7b#diff-5641e34a6f945196e79a576e6406eb4690ee5e34624ccedfcc8e42157e23bd06.