search

WalletConnect / walletconnect-monorepo

WalletConnect Monorepo
Apache License 2.0
1.26k stars 626 forks source link

Domain verification is incorrectly generated for `.it.com` TLD #4471

Closed raviriley closed 1 month ago

raviriley commented 2 months ago

Discussed in https://github.com/orgs/WalletConnect/discussions/4451

When adding a domain with the `.it.com` TLD, the Verify API looks for the DNS record at [it.com](https://get.it.com). This is broken and needs to be fixed.
linear[bot] commented 2 months ago

CR-16 Domain verification is incorrectly generated for `.it.com` TLD

raviriley commented 2 months ago

This is currently preventing anyone with a .it.com domain from using WalletConnect. Any chance a patch can be pushed ASAP similar to how .co.uk behaves?

raviriley commented 2 months ago

@Cali93 @bkrem @glitch-txs any chance this can be patched this month? 🙏

Cali93 commented 2 months ago

@raviriley Thanks for raising this. We will ship a fix in the upcoming days.

This is currently preventing anyone with a .it.com domain from using WalletConnect

Just as a clarification, it's preventing them from using Verify API, not the whole WalletConnect Protocol.

raviriley commented 2 months ago

Awesome! You're right, thanks for the clarification 👌

Cali93 commented 1 month ago

Hey @raviriley,

We updated our implementation and TLDs like .it.com are now parsed correctly.

Thanks for your patience 🙏

raviriley commented 1 month ago

Awesome, thanks @Cali93 🥳