Open antondalgren opened 6 days ago
From the logs, it looks like the call to persist fails/is slow since later when trying to read from history it fails to find the entry. https://github.com/WalletConnect/walletconnect-monorepo/blob/5899f274aaf97f0ae0726d227474655edb526f2e/packages/core/src/controllers/history.ts#L88
Describe the bug If there is an error in the SDK after we have sent a response to a request, it is not possible to process a new request until that one has expired.
If any of these send methods throws an error, the cleanup method isn't called and the engine will not have it's state changed from
active
toidle
and thus it will block any new request from being processed. https://github.com/WalletConnect/walletconnect-monorepo/blob/5899f274aaf97f0ae0726d227474655edb526f2e/packages/sign-client/src/controllers/engine.ts#L516-L520I have experienced this error to be thrown locally: https://github.com/WalletConnect/walletconnect-monorepo/blob/5899f274aaf97f0ae0726d227474655edb526f2e/packages/sign-client/src/controllers/engine.ts#L1248-L1249
I'm not sure if the intention is that we are supposed to handle the error in this case or if there is something to be added to the SDK to ensure that the message has been transmitted successfully.
SDK Version (if relevant)
To Reproduce Steps to reproduce the behavior:
Expected behavior A clear and concise description of what you expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Error Logs: