Closed devceline closed 9 months ago
Looks like the context is linking back to all the spec PRs, could you reference back to the relevant concrete change pls so I have the correct point of reference 🙏
Added viem for signature verification (ignoreDeprecations: "5.0" in tsconfig added to allow that)
Not clear on how this relates to each other, was the tsconfig blocking the usage of viem
?
Looks like the context is linking back to all the spec PRs, could you reference back to the relevant concrete change pls so I have the correct point of reference 🙏
Clipboard mishap - fixed
Added viem for signature verification (ignoreDeprecations: "5.0" in tsconfig added to allow that)
Not clear on how this relates to each other, was the tsconfig blocking the usage of
viem
?
Yes - I believe this is because viem
uses typescript 5.0. Speaking of which, is there anything blocking us from upgrading?
Yes - I believe this is because
viem
uses typescript 5.0. Speaking of which, is there anything blocking us from upgrading?
No nothing blocking, just a matter of putting in the legwork to fix up all the loose ends across the packages if upgrading the whole monorepo to typescript@5
. Probably a good one for tech debt week :)
Tagging you @bkrem again just to lookover the major version bump
Changes
Refactor how identity keys signing:
onSign
, instead split the registration function into two:prepareRegistration
: generate an identity keypair, format a cacao payload and a cacao messageregister
: actually perform the registration on the keyserver and persist the keys if successful, using externally provided signatureviem
for signature verification (ignoreDeprecations: "5.0"
in tsconfig added to allow that)Context
For the notify SDK to comply with the new specs added here, splitting the registration function, this util needs to do the same.