WalletConnect / walletconnect-utils

Javascript Utilities for WalletConnect
MIT License
65 stars 56 forks source link

Refactor/identity keys persistence and signing #154

Closed devceline closed 9 months ago

devceline commented 9 months ago

Changes

Refactor how identity keys signing:

Context

For the notify SDK to comply with the new specs added here, splitting the registration function, this util needs to do the same.

bkrem commented 9 months ago

Looks like the context is linking back to all the spec PRs, could you reference back to the relevant concrete change pls so I have the correct point of reference 🙏

bkrem commented 9 months ago

Added viem for signature verification (ignoreDeprecations: "5.0" in tsconfig added to allow that)

Not clear on how this relates to each other, was the tsconfig blocking the usage of viem?

devceline commented 9 months ago

Looks like the context is linking back to all the spec PRs, could you reference back to the relevant concrete change pls so I have the correct point of reference 🙏

Clipboard mishap - fixed

devceline commented 9 months ago

Added viem for signature verification (ignoreDeprecations: "5.0" in tsconfig added to allow that)

Not clear on how this relates to each other, was the tsconfig blocking the usage of viem?

Yes - I believe this is because viem uses typescript 5.0. Speaking of which, is there anything blocking us from upgrading?

bkrem commented 9 months ago

Yes - I believe this is because viem uses typescript 5.0. Speaking of which, is there anything blocking us from upgrading?

No nothing blocking, just a matter of putting in the legwork to fix up all the loose ends across the packages if upgrading the whole monorepo to typescript@5. Probably a good one for tech debt week :)

devceline commented 9 months ago

Tagging you @bkrem again just to lookover the major version bump