WalletConnect / web3modal-react-native

Web3Modal React-Native SDK
https://web3modal.com
Apache License 2.0
51 stars 16 forks source link

Provider logic + Controllers #2

Closed ignaciosantise closed 1 year ago

ignaciosantise commented 1 year ago

Summary

Screenshots

iOS

https://user-images.githubusercontent.com/25931366/229607879-c122469b-f58c-403a-bab5-cc08674c7b3d.MP4

Android

https://user-images.githubusercontent.com/25931366/231514967-62fcc8ec-f139-435e-bf5b-22e2150b72ef.mp4

ignaciosantise commented 1 year ago

Thanks for your feedback @0xAsimetriq 🎉

About image sizes, im following react-native docs recommendations, and i think there's no maintenance problem because Figma has the option to export in all sizes.

crypblizz8 commented 1 year ago

I left few comments on code style, that apply all around. I think it might be time to introduce tools like eslint / prettier to catch them? Also perhaps set up github actions to run these checks on pr's (refference in web repo).

+1 @0xAsimetriq so let's add some GHub Actions for this. Maybe also let's consider leaving an Expo Snack as our version of Vercel. Then we can easily scan without having to do the xCode / RN CLI setup each time? Do you know of any other streamlined flows @ignaciosantise ?

ignaciosantise commented 1 year ago

@crypblizz8 the repo has some actions, but they execute when the base of the PR is main.

Screen Shot 2023-04-05 at 09 54 49

I'll try to add the QR Code for expo 🎉 good idea

crypblizz8 commented 1 year ago

NonBlocking: Let's also add a README to the main directory and for examples.

crypblizz8 commented 1 year ago

NonBlocking: when I did a yarn on the examples repo, it asked me to ✔ It looks like you're trying to use TypeScript but don't have the required dependencies installed. Would you like to install typescript@^4.9.4, @types/react@~18.0.27? … yes

Is this something we need to add or is it more an expo thing?

crypblizz8 commented 1 year ago

IMG_8664 Running into this while doing examples. I did yarn and normal Expo scan/ login. Added projectID. Anything I am missing?

ignaciosantise commented 1 year ago

NonBlocking: when I did a yarn on the examples repo, it asked me to ✔ It looks like you're trying to use TypeScript but don't have the required dependencies installed. Would you like to install typescript@^4.9.4, @types/react@~18.0.27? … yes

Is this something we need to add or is it more an expo thing?

To run this example go to the root folder and:

  1. Run yarn to install all deps
  2. Run yarn example android or yarn example ios