search

WalletConnect / web3modal-react-native

Web3Modal React-Native SDK
https://web3modal.com
Apache License 2.0
51 stars 16 forks source link

Failed to decrypt error #22

Closed Mostafatalaat770 closed 1 year ago

Mostafatalaat770 commented 1 year ago

Using this snippet while connected to trust wallet https://github.com/WalletConnect/web3modal-react-native/blob/388090a82e99b3e4cfe6a7b149c1e10ab2fc228a/example/src/utils/MethodUtil.ts#L41-L48

causes failed to decrypt error, but I found something interesting when opened the wallet provider app this happens: image I added a log when it enters onSessionDelete in useConfigure hook, and as you see the sessions are not in sync or something is not right. the first one is from the event and the second is from the clientCtrl.

and it shows to sign the message normally, but on accepting, it throws the failed to decrypt error, so most probably it's a wallet connect issue than a modal issue, what do you think?

Originally posted by @Mostafatalaat770 in https://github.com/WalletConnect/web3modal-react-native/issues/13#issuecomment-1536137085

desfero commented 1 year ago

Can confirm the same error started to happen for me without any code changes. Last time (somewhere around 2 weeks ago) TrustWallet was working fine.

StevenBarnett1 commented 1 year ago

Same here!

finessevanes commented 1 year ago

Your issue has been viewed and shared with our development team for review.

ignaciosantise commented 1 year ago

Update on this issue: we reached Trust Wallet team and apparently the issue will be solved in their next release, that is currently in Apple's review. Let's wait for that release 💪

StevenBarnett1 commented 1 year ago

Any update here? Bug still in effect.

ignaciosantise commented 1 year ago

hey @StevenBarnett1 no updates yet 👎 We reached Trust team again yesterday

boulinb commented 1 year ago

Hey @ignaciosantise !

Has the TrustWallet team given you a date for resolving the bug?

ignaciosantise commented 1 year ago

hey @boulinb, they didn't provide an estimated time, but i tested their latest version in TestFlight and the problem is solved 🤝

boulinb commented 1 year ago

hey @boulinb, they didn't provide an estimated time, but i tested their latest version in TestFlight and the problem is solved 🤝

That's great news! Can't wait for them to go into production!

ignaciosantise commented 1 year ago

@boulinb @Mostafatalaat770 @StevenBarnett1 Trust Wallet v8.9 is now available 🎉 Can you confirm the issue is solved on your side?

boulinb commented 1 year ago

Hey @ignaciosantise

Tested on iOS version (16.3.1), great news everything works fine! 🎉

bujoralexandru commented 1 year ago

Hey guys,

Indeed, it is working on Trust Wallet v8.9, except eth_sendTransaction. This actions does not work and just hangs. I'll upload a video in this comment demonstrating a few working methods and I'll end with the hang when trying to call eth_sendTransaction.

https://github.com/WalletConnect/web3modal-react-native/assets/17970235/709edc4b-e819-4521-a714-6c36a096d53a

ignaciosantise commented 1 year ago

Great! Im closing this issue as it is solved in latest Trust Wallet version (v8.9 in iOS)

ignaciosantise commented 1 year ago

Also please check the deprecation notice here, we decided to migrate this lib to @walletconnect/modal-react-native

bujoralexandru commented 1 year ago

@ignaciosantise, does your latest comment address the issue I highlighted in the screen-capture above?

Sorry if I'm insistent, but maybe one of your answers was regarding the problem I mentioned and I just missed the point.