search

WalletConnect / web3modal-react-native

Web3Modal React-Native SDK
https://web3modal.com
Apache License 2.0
46 stars 15 forks source link

chore: dependencies update #23

Closed Mostafatalaat770 closed 1 year ago

ignaciosantise commented 1 year ago

hey @Mostafatalaat770 👋 thanks for the PR!

Just one comment, the yarn.lock file should only have changes related to the specific package updates. Can you revert that file, and run the updates again? After that, the lock file should have less changes.

Also, did you tested the changes with the example app?

I'll test it too, and upload some screenshots.

ignaciosantise commented 1 year ago

@Mostafatalaat770

The correct steps to follow should be:

  1. Restore previous yarn.lock
  2. Run yarn add @walletconnect/react-native-compat@2.7.4
  3. Run yarn add @walletconnect/universal-provider@2.7.4

that way, the lock file will update the related packages only

Mostafatalaat770 commented 1 year ago

@ignaciosantise it was an error from my side, my bad. you can just squash and merge when approved

Mostafatalaat770 commented 1 year ago

Perfect 🎉