search

WalletConnect / web3modal

A single Web3 provider solution for all Wallets
https://web3modal.com
Apache License 2.0
4.69k stars 1.3k forks source link

Missing images on Mobile Dapp Browsers #14

Closed pedrouid closed 4 years ago

pedrouid commented 5 years ago

Context

A previous issue (#12) was open to solve the issue with missing images that weren't bundled with Webpack. This was successful and you can know see on the live demo at web3connect.netlify.com that the images are present on the modal when you click the button.

However this issue still remains for a very specific use-case. It works on Mobile browsers but not a Mobile Dapp Browser. For example: open the same live demo on Trust Wallet's Dapp Browser (only tested on iOS) and you will see that the image is not loaded.

Goal

Find a solution that will display bundled images on Trust Wallet's Dapp Browser for both Android and iOS

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to it as part of the WalletConnect fund.

pedrouid commented 5 years ago

This is how it looks like currently on the iOS Trust Wallet's Dapp Browser

IMAGE 2019-05-22 14:40:01

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 month, 1 week from now. Please review their action plans below:

1) surajkelhe has started work.

I will try to find best ways to show bundled imaged using webpack and thrn create a way which can fix this bug 2) chiradeep7 has started work.

Hi, following link can help you: https://docs.opensea.io/reference 3) dannielboy58 has started work.

An inspection of the frfontend codes to check for correct spanning and path definition of images....also checks in the javascript code to check for library import omissions 4) youssefsoosef has started work.

I will change the image type from SVG to PNG 5) gutsal-arsen has started work.

Fix image display on Trust Wallet Dapp browser.

Learn more on the Gitcoin Issue Details page.

janus commented 5 years ago

@pedrouid
How is this issue going? Have you being able to test it on Android ?

pedrouid commented 5 years ago

Not sure, @surajkelhe and @chiradeep7 could you provide an update if you are have a PR ready to go soon. Otherwise, feel free to jump on it as well @janus.

aahutsal commented 4 years ago

@pedrouid any update? still need some help? lemme know and I'll participate on gitcoin bounty

pedrouid commented 4 years ago

Hi @gutsal-arsen, this bounty is still live. Feel free to jump on it!

aahutsal commented 4 years ago

@pedrouid Expressed my interest on Gitcoin.

pedrouid commented 4 years ago

@agutsal Just extended the bounty and approved your application.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 50.0 DAI (50.0 USD @ $1.0/DAI) has been submitted by:

  1. @gutsal-arsen

@pedrouid please take a look at the submitted work:

pedrouid commented 4 years ago

Awesome! Just tested it and works perfectly! Thanks @agutsal! 👍

gitcoinbot commented 4 years ago
Bug Squasher ⚡️ A *Bug Squasher* Kudos has been sent to @gutsal-arsen for this issue from @pedrouid. ⚡️ Nice work @gutsal-arsen! Your Kudos has automatically been sent in the ETH address we have on file.
aahutsal commented 4 years ago

@pedrouid thanks for Kudos ;)

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 50.0 DAI (50.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @gutsal-arsen.