WalletConnect / web3modal

A single Web3 provider solution for all Wallets
https://web3modal.com
Apache License 2.0
4.67k stars 1.28k forks source link

fix: switch network test flakyness #2175

Closed tomiir closed 3 weeks ago

tomiir commented 3 weeks ago

Breaking Changes

N/A

Changes

Fixes isssue where switch network test would have flaky behavior due to the modal being closed too quickly, causing following modal openings to close prematurely. Modified the test to better reflect user flow by expecting the screen to return to account view and show the apropiate network.

Screenshot

image 🤣

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3modal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 5:05pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Apr 22, 2024 5:05pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Apr 22, 2024 5:05pm
github-actions[bot] commented 3 weeks ago

Coverage Report for Coverage

Status Category Percentage Covered / Total
🔵 Lines 81.49% 2520 / 14979
🔵 Statements 81.49% 2520 / 14979
🔵 Functions 89.71% 122 / 509
🔵 Branches 119.62% 182 / 484
File CoverageNo changed files found.
Generated in workflow #3329
lukaisailovic commented 3 weeks ago

Its good that we reduced timeouts as well 👌

enesozturk commented 3 weeks ago

@tomiir Let's merge this to unblock other PRs. We could raise another PR if we need.