vercel[bot]
commented
3 weeks ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| web3modal-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 25, 2024 5:39pm |
| web3modal-gallery | ✅ Ready (Inspect) | Visit Preview | Apr 25, 2024 5:39pm | |
| web3modal-laboratory | ✅ Ready (Inspect) | Visit Preview | Apr 25, 2024 5:39pm |
github-actions[bot]
Changes
Modal animation refactor
We are using JS-based animations which have some regression issues. When we click the account button too fast, this will try to open and close the modal too fast and after some point, the modal goes into a state where it's trying to run animation before the previous animation didn't end.
This could be fixed in several ways. When it comes to animations, the CSS only solution is the best when it comes to performance. This PR introduces changes to our modal open/close animations and moves them to a CSS solution.
Steps to reproduce
Switch network test logic
While we switch networks, we don't properly wait for the required changes. This is causing test runners to go into weird states or close the modal in unexpected situations.
Now, we are waiting for the network switch button to have switched the network name to complete the switch network logic. This addresses most of the regression issues.