search

WalletConnect / web3modal

A single Web3 provider solution for all Wallets
https://web3modal.com
Apache License 2.0
4.67k stars 1.28k forks source link

[Draft] feat: support web3js #2205

Open Muhammad-Altabba opened 2 weeks ago

Muhammad-Altabba commented 2 weeks ago

This is currently just a draft.

This MR is to support using web3.js with web3modal.

Breaking Changes

N/A

Changes

Associated Issues

N/A

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ❌ Failed (Inspect) May 16, 2024 6:17pm
vercel[bot] commented 2 weeks ago

@Muhammad-Altabba is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

glitch-txs commented 1 week ago

Hi thanks for the effort, we won't be adding another package but rather simplify support into a single one for ethers and web3js

Muhammad-Altabba commented 1 week ago

Hi thanks for the effort, we won't be adding another package but rather simplify support into a single one for ethers and web3js

Thanks @glitch-txs, We hope this PR gives some ideas on how web3.js could be used with web3modal. Let us know please if we need to provide support for the code changes that would simplify the support of ethers and web3.js into the anticipated single package.

And for now, I published a temporary package as a demo at: https://www.npmjs.com/package/web3modal-web3js

Best regards,

glitch-txs commented 1 day ago

Thanks @Muhammad-Altabba! We are planning to migrate from ethers support to a more agnostic approach by exposing the wallet provider on its own so devs would be able to work/choose any ethereum library they wish to use