search

WalletConnect / web3modal

A single Web3 provider solution for all Wallets
https://web3modal.com
Apache License 2.0
4.69k stars 1.3k forks source link

Torus Integration with web3Connect #81

Closed YZhenY closed 4 years ago

YZhenY commented 4 years ago

Torus integration to web3Connect. PR includes:

crisgarner commented 4 years ago

hey @YZhenY I'm testing this at the moment, but can't get to run tours on the example. I'm adding torus: {} to the list of providers but nothing happens

YZhenY commented 4 years ago

yo @crisgarner, with the examples, the master branch doesn't pop up the model. i didnt have the time to dive into why, perhaps i could get some help there

if you npm pack this branch and install it on a blank app it works as intended

crisgarner commented 4 years ago

Hey @YZhenY it works fine! there is just an issue when you hit disconnect, Torus keeps connected.

YZhenY commented 4 years ago

Thanks for checking up @crisgarner - facing an issue with utilizing the Torus object with the logout function. Whilst we can include the logout feature on the provider, do you think we could find some way to expose the functions somehow other than tossing it on the provider?

For example, Torus provides an email resolver to public keys for dapps to use via its object. Would love to expose this

crisgarner commented 4 years ago

Maybe this PR is the one you need? https://github.com/web3connect/web3connect/pull/65

YZhenY commented 4 years ago

That would work!

pedrouid commented 4 years ago

This PR should wait for the refactor on #79

YZhenY commented 4 years ago

sure that makes sense @pedrouid and @crisgarner, whats the timeline to getting them merged

pedrouid commented 4 years ago

Hi @YZhenY, I merged it yesterday and already published it with release beta.22.

lukasschor commented 4 years ago

I recommend using a PNG of the Google icon as it looks better in hover state.

Screenshot 2019-09-16 at 11 20 02

Also I find the wording confusing. I would just say "Google" as the main title and then use "Connect to (/with) your Google account via (/using) Torus" as a subtitle.

pedrouid commented 4 years ago

I agree with @lukasschor feedback, also @YZhenY wouldn't it be possible to allow Torus integration to have multiple social logins. Why does it need to be "via Google"? Couldn't we provide a Torus integration which then displays an option to select different social logins?

YZhenY commented 4 years ago

thanks for the feedback @lukasschor @pedrouid. We'd always go for the most intuitive copywriting, I've also adjusted the png.

With regards to multiple logins @pedrouid, it is possible to support additional logins, but the flows aren't implemented in production just yet. Will adjust the integration when it is.

Since #65 isn't merged yet, I've defaulted the UI to be hidden through web connect. Once it is we can utilize the cleanup flow on the torus object.

Let me know anything else I can do @pedrouid @crisgarner to get this merged. Have people keen to use Web3Connect and Torus!

YZhenY commented 4 years ago

Any updates here guys? Keen to push this forward

YZhenY commented 4 years ago

@crisgarner @pedrouid

crisgarner commented 4 years ago

@YZhenY tested everything and works fine! Thanks, merged now

hainusii commented 3 years ago

Torus integration to web3Connect. PR includes:

  • Added provider/connector
  • Included logo
  • Tested with npm pack
  • Added Torus to readme
  • Adjusted webpack versioning for npm link