search

WalletWasabi / WabiSabi

MIT License
100 stars 27 forks source link

Various minor improvements #45

Closed nothingmuch closed 4 years ago

nothingmuch commented 4 years ago

This pull request contains a number of relatively independent minor changes like rewording for grammar or clarity, making terminology more precise, or moving things around. Changes which depend on each other for consistency or are related are grouped into individual commits.

nothingmuch commented 4 years ago

I added 2 additional commits as discussed in today's call, to swap G_g and G_h and to rename M_v etc to M_a (avoiding confusion between G_v and G_V)

nopara73 commented 4 years ago

@seresistvanandras?

seresistvanandras commented 4 years ago

Just pushed my only major change I'd like to see in the next version. Although I still have many nits but I will add them just to Overleaf as of now, as they're not that significant. But looks good to me.

nopara73 commented 4 years ago

Is https://github.com/zkSNACKs/WabiSabi/pull/45/commits/163c2e77b36fadd7563067d0b323f307c4983159 your major change? 😄

seresistvanandras commented 4 years ago

Sadly yes. These days I don't have time to work on this more intensely...