Clear up number of blind commitments

WalletWasabi / WabiSabi

MIT License

105 stars 28 forks source link

Clear up number of blind commitments #8

Closed MaxHillebrand closed 4 years ago

MaxHillebrand commented 4 years ago

The current version was confusing with mentioning two types of numbers right next to each other: the quantity of commitments and the btc value of commitments. In this branch, I change it so that the quantity of commitments is written out, like ten instead of 10.

[There's also a minor typo fix to CoinJoins.]

MaxHillebrand commented 4 years ago

Sorry about the git mess... It's mergable now. I can redo and make a new PR properly on an up to date master, if you care about the git commit history being clean.

yahiheb commented 4 years ago

You can clean that by doing a squash https://github.com/wprig/wprig/wiki/How-to-squash-commits

Summary:

Make sure your branch is up to date with the master branch

git rebase -i master

Make sure the first commit says "pick" and change the rest from "pick" to "squash"

git push --force-with-lease origin