search

WalletWasabi / WalletWasabi

Open-source, non-custodial, privacy preserving Bitcoin wallet for Windows, Linux, and Mac.
https://wasabiwallet.io
MIT License
2.14k stars 499 forks source link

Using manual coin selection in tx preview results in change avoidance being canceled unnecessarily #11950

Open BTCparadigm opened 10 months ago

BTCparadigm commented 10 months ago

General Description

When you try to make a payment using change avoidance, but you want to manually switch the coin that is selected automatically in to a similar one (same value and script type), the change avoidance is being canceled and the payment amount reverts back to the amount user typed before the transaction preview. In practice, this results in an annoying situation where you have to choose between making a payment with change output, or a payment with unconfirmed coins, because the robot doesnt understand better and the manual coin selection doesnt let you do better, even if you knew how.

How To Reproduce?

  1. Have a bunch of private coins with same value
  2. Use change avoidance
  3. Long press ALT and click the "review coins" hyperlink
  4. Switch another coin of the same script type and value to the originally selected one and click continue
  5. See the payment amount has changed back to the amount you typed before tx preview, that there is a warning of this tx producing a change output again, and that you are suggested to change the payment value in order to avoid change

Operating System

Win11

Wasabi Version

2.0.4

MaxHillebrand commented 9 months ago

if user does change avoidance, then goes to the coin selection, whichever coins he selects, the transaction should now create no change.

molnard commented 6 months ago

I can reproduce this.

molnard commented 6 months ago

I talked with Roland and he said https://github.com/zkSNACKs/WalletWasabi/issues/12364 will fix this issue. You will be able to select coins and do the tx with them + changeless option.

adamPetho commented 5 months ago

This is still relevant. I just removed my assigment, since I won't maintain this in the future.

In the past I proposed the solution to allow the user to change the selected coins and if the TX can stay change-free, then just go with it. Obviously, that was NACK because of "bad UX" :)

BTW this sorting block is not bad UX apparently, since we shipped it............... image