search

WalletWasabi / WalletWasabi

Open-source, non-custodial, privacy preserving Bitcoin wallet for Windows, Linux, and Mac.
https://wasabiwallet.io
MIT License
2.16k stars 501 forks source link

External taproot addresses #12088

Closed MaxHillebrand closed 1 month ago

MaxHillebrand commented 10 months ago

It's a privacy improvement to also generate taproot addresses for external receive addresses. There could be a button to show segwit v0 addresses if the sender wallet does not support sending to taproot.

soosr commented 10 months ago

Can we switch to Taproot by default? or is too early?

MarnixCroes commented 10 months ago

Some big exchanges seem to not support sending to bech32m yet https://whentaproot.org/#support

soosr commented 10 months ago

ok, I would propose still generating Bech32 by default, but giving an option for Taproot, once Taproot becomes more popular we can switch.

If there won't be any objection, until the next release, I will start making a UX design for it.

MaxHillebrand commented 10 months ago

ok, I would propose still generating Bech32 by default, but giving an option for Taproot, once Taproot becomes more popular we can switch.

CACK

kristapsk commented 10 months ago

There are reasons from privacy perspective to still use P2WPKH addresses instead of P2TR, for example, if you know that senders wallet uses P2WPKH addresses. https://en.bitcoin.it/wiki/Privacy#Sending_to_a_different_script_type

Kruwed commented 1 month ago

Fixed: https://github.com/WalletWasabi/WalletWasabi/pull/13294