search

WalletWasabi / WalletWasabi

Open-source, non-custodial, privacy preserving Bitcoin wallet for Windows, Linux, and Mac.
https://wasabiwallet.io
MIT License
2.12k stars 498 forks source link

Labels no longer mandatory #6378

Open MaxHillebrand opened 3 years ago

MaxHillebrand commented 3 years ago

The reason why in Wasabi 1.0 labels were mandatory, was because coin selection was mandatory, for both spending and coinjoin. And the label was the only metadata that could help the user make this decision.

In Wasabi 2.0, when we assume that auto CoinJoin is activated, then there is no manual coin selection for either CoinJoin nor spending. Therefor, there is no more reason to mandate user input for the label.

I suggest to remove the mandate for labels, in the case that Auto CoinJoin is activated. The label field should still be visible in the send tab, but no longer required to continue.

The Receive flow should be reduced to one dialog screen, where it shows the QR code, address text, and optional label textbox on one screen.

Even though we assume auto CoinJoin for UX simplification, the wallet should still be usable even when no [auto] CoinJoin is made, in which case the cluster selection screen comes with every spending transaction. Thus when Auto CoinJoin is deactivated, labels should be mandatory again.

Kruwed commented 1 year ago

ACK.

nostitos commented 2 months ago

I just want a bunch of addresses, Fuck sake!

image

This big empty area with only 3 old labels, WHY???

MarnixCroes commented 2 months ago

I just want a bunch of addresses, Fuck sake!

image

This big empty area with only 3 old labels, WHY???

Try the RPC, better UX for that https://docs.wasabiwallet.io/using-wasabi/RPC.html#listkeys