WalletWasabi / WasabiDoc

This is the Wasabi documentation, an archive of knowledge about the open-source, non-custodial and privacy-focused Bitcoin wallet for desktop.
https://docs.wasabiwallet.io
MIT License
97 stars 83 forks source link

Play embedded youtube videos within the docs #1394

Open yahiheb opened 1 year ago

yahiheb commented 1 year ago

The videos now open up a new tab in YouTube. They used to be embedded and play within the docs.

https://github.com/zkSNACKs/WasabiDoc/pull/1247#issuecomment-1339747268 https://github.com/zkSNACKs/WasabiDoc/pull/1247#issuecomment-1342209641

Possible solution: https://github.com/vuepress/vuepress-next/discussions/1182

jesseaam commented 1 year ago

Possible solution: https://github.com/vuepress/vuepress-next/discussions/1182

I think this would be a great solution, though I've been having trouble getting it to work. When you install the plugin vuepress-plugin-components@next it causes the docs not to show up anymore.

Documentation

Running the current master this is what you see when you start the development server: ``` npm start > wasabidoc@0.1.0 prestart > rm -rf $npm_package_config_dist > wasabidoc@0.1.0 start > vuepress dev docs warning an anonymous plugin or theme was detected and ignored warning an anonymous plugin or theme was detected and ignored warning an anonymous plugin or theme was detected and ignored ✔ Initializing and preparing data - done in 986ms vite v3.1.8 dev server running at: ➜ Local: http://localhost:8080/ ```
Now install the plugin: ``` $ npm i -D vuepress-plugin-components@next added 326 packages, removed 2 packages, changed 24 packages, and audited 795 packages in 21s 78 packages are looking for funding run `npm fund` for details 6 vulnerabilities (2 moderate, 4 high) To address issues that do not require attention, run: npm audit fix Some issues need review, and may require choosing a different dependency. Run `npm audit` for details. ```
Running the current master AFTER INSTALLING PLUGIN this is what you see when you start the development server: ``` $ npm start > wasabidoc@0.1.0 prestart > rm -rf $npm_package_config_dist > wasabidoc@0.1.0 start > vuepress dev docs warning an anonymous plugin or theme was detected and ignored warning an anonymous plugin or theme was detected and ignored warning an anonymous plugin or theme was detected and ignored ✔ Initializing and preparing data - done in 1.19s vite v4.0.0 dev server running at: ➜ Local: http://localhost:8080/ ```

In short the difference you see is before and after installing the plugin:


I started a discussion here on GitHub Discussions, so maybe the community there will have some tips.

MarnixCroes commented 11 months ago

What's the status of this? @CAnorbo any ideas?