Adding branch protection to `master` branch

WalletWasabi / WasabiWalletWebSite

MIT License

4 stars 10 forks source link

Adding branch protection to `master` branch #4

Closed kristapsk closed 1 year ago

kristapsk commented 1 year ago

As we auto deploy on commits in master, I think we should look at adding some GitHub restrictions to it.

IMO no direct commits to master branch should be allowed, instead it should be forced through PRs with at least ACK review.

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches

nopara73 commented 1 year ago

molnard commented 1 year ago

Done

kristapsk commented 1 year ago

Tested, works.

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Changes must be made through a pull request.
To github.com:zkSNACKs/WasabiWalletWebSite.git
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'github.com:zkSNACKs/WasabiWalletWebSite.git'