WalonLi / edk2-vscode

The VSCode plugin of EDKII file association.
Other
31 stars 9 forks source link

[Feature request] List the section names on the right of the file name #3

Closed JamesAmiTw closed 2 years ago

JamesAmiTw commented 2 years ago

Hi Walon,

Is it possible to add a feature like other languages did?
In the picture below, it lists all the functions and variables. Can we list the sections of dsc/dec/inf like [PcdFeatureFlag], [Protocols], [Sources], etc. for better navigation. Thanks!

螢幕擷取畫面 2021-11-24 222542

WalonLi commented 2 years ago

Good idea, thanks @JamesAmiTw It's possible and not difficult to implement. I'll take time to do this this month(or two months?😊).

JamesWangAmiTw commented 2 years ago

@WalonLi

Thank you for the help! 💯 Just take your time.

WalonLi commented 2 years ago

@JamesWangAmiTw 1.0.5 is published. Outline function is ready for INF/DSC/DEC now. Please close if no more comment. 1 2

JamesAmiTw commented 2 years ago

@WalonLi Thank you for the effort!

I am closing this request.

But... there is always a but XD

I was hoping that it can show the name on the top when focus is within the scope of the outline. Take the example below, it shows "..." only, not the "FeaturePcd" because the focus is on the PcdPciBusHotplugDeviceSupport 圖片

It only show FeaturePcd when the focus is right on the [FeaturePcd] itself: 圖片

Sometimes PCDs in the same section are more than a page and I have to open the side bar then search to check which section this PCD is belong to, or to just scroll pages up and up and up. If it can directly show the section name where the focused line is belong to (on the top) it will help me to save some time. This is my original intention but I didn't make it clearly described.

WalonLi commented 2 years ago

@JamesAmiTw Got it. Will submit a new PR and set you as reviewer for eliminating any gap between us. Thanks!

JamesAmiTw commented 2 years ago

@WalonLi Thank you!