keypoint_score in dataset_action.py

Walter0807 / MotionBERT

[ICCV 2023] PyTorch Implementation of "MotionBERT: A Unified Perspective on Learning Human Motion Representations"

Apache License 2.0

1k stars 120 forks source link

keypoint_score in dataset_action.py #132

Closed fneaplle closed 4 months ago

fneaplle commented 4 months ago

Hello. Thank you for your research.

While applying your research to my data, I discovered a problem.

https://github.com/Walter0807/MotionBERT/blob/1839f099ce9f128342c8f5499478ace328c0df4a/lib/data/dataset_action.py#L152

I think motion_conf = sample['keypoint_score[..., None]'] should be changed to motion_conf = coco2h36m(sample['keypoint_score[..., None]']) (line 152 in dataset_action.py)

Could you please check if what I thought is correct? @Walter0807

Walter0807 commented 4 months ago

Seems like a good catch. Feel free to open a PR if you want. It would also be great if you can report the performance after fix!

fneaplle commented 4 months ago

Can I close this issue? After conducting the experiment, I will post a PR with performance report. Thank you for answer