search

WaltersArtMuseum / api-thewalters-org

Repository for the Walters Art Museum collections API. This API provides images and data about objects in the collection of the Walters Art Museum in Baltimore, Maryland.
https://api.thewalters.org/
46 stars 4 forks source link

proposed: combine all 'not on view' locations #42

Closed dylan-k closed 6 years ago

dylan-k commented 10 years ago

Currently, there are many locations named 'not on view'. This is because, for the museum, there are multiple locations that are not available to the public, but since these are all named 'not on view' it can be confusing/difficult to see so many of them in the results of get locations.

@kateblanch says she can merge these together, but needs to check with @johnbabb to make sure it is safe to do so.

kateblanch commented 10 years ago

John, I would change the museum location view by adding a case statement to the location id field and by modifying the existing case statement for the display current location field. This should not affect the data output...but I wanted to make sure you were ok with these view changes.

kateblanch commented 10 years ago

@johnbabb -- the change to the Not on View locations looks like a go. The only view dependency I need to ask you about --

wam_API_ObjectMuseumLocationLkp -- is this view in use? If yes...I need to apply the same case statements to it. If it is in use, isn't it redundant with wam_API_museumLocation_LKP?

Let me know your thoughts, thanks!

kateblanch commented 10 years ago

@johnbabb -- I just discovered this dependency: wam_API_Objects_By_Locations refers to wam_API_ObjectMuseumLocationLkp. To remedy this...could I replace wam_API_ObjectMuseumLocationLkp with wam_API_MuseumLocation? THis would allow us to eliminate redundancy.

Thanks!

johnbabb commented 10 years ago

@kateblanch , we will have to talk this over more, would say yes, but i'm not following what you want to do.

kateblanch commented 10 years ago

@johnbabb -- great, maybe at the end of our call on Wednesday we can Skype screen share and I can show you what I mean.

johnbabb commented 10 years ago

Will look into if we can swap wam_API_ObjectMuseumLocationLkp with wam_API_MuseumLocation. See if we can change the wam_API_Objects_By_Locations to use wam_API_MuseumLocation.