search

WaltersArtMuseum / api-thewalters-org

Repository for the Walters Art Museum collections API. This API provides images and data about objects in the collection of the Walters Art Museum in Baltimore, Maryland.
https://api.thewalters.org/
46 stars 4 forks source link

Typo in Image Processing Documentation #65

Closed kateblanch closed 10 years ago

kateblanch commented 10 years ago

This typo/issue was reported by a JHU user. The 'rotate' parameter does not take angle-(some number), as specified here

https://github.com/WaltersArtMuseum/walters-api/blob/master/images.md it just takes in a rotation angle. To be clear, let me give an example,

http://static.thewalters.org/images/PS1_61.347_Fnt_DD_T08.jpg?rotate=angle-54 is not working

http://static.thewalters.org/images/PS1_61.347_Fnt_DD_T08.jpg?rotate=54 is working

@dylan-k , @johnbabb -- should I update the documentation to reflect this? Just want to double check.

johnbabb commented 10 years ago

This is a bug with the lib we use. I don’t think we document it anywhere but link to the github docs for this lib. We should pass this information along, or look at what have documented and make sure it aligns with the lib docs.

kateblanch commented 10 years ago

I corrected this. Thanks guys!