Walther / clovers

Ray Tracing in Rust
https://walther.github.io/clovers/clovers/
13 stars 1 forks source link

Are init-structs code-smelly? #49

Open Walther opened 3 years ago

Walther commented 3 years ago

Currently, the codebase has separate internal representation structs for the various objects, and separate init structs for the representations in the scene.json files.

Is this a good/bad thing? On one hand, it feels like there might be a lot of repetition. On the other hand, see e.g. https://github.com/Walther/clovers/pull/46 and https://github.com/Walther/clovers/issues/47 - these could potentially benefit from multiple init structs existing / more flexibility in the input...