d2roth
commented
7 years ago Hey @carlzata, I ran into that issue and made some modifications to this script. This was only tested on our servers and my local environment but it does the trick for us.
Some improvements that should be done but I haven't had the time to do include, checking if the ftp connection succeeds before closing the connection so in BitBucket/GitHub you at least know that the connection is fine in the hook. Also there is no way of knowing if a deployment is ongoing except if you read the logfile.txt. So I don't know what would happen if 2 repositories got pushed to at similar times.
Anyways without further ado here is my solution:
Basically I used ignore_user_abort(true). I believe this will work with FTPBucket in its current state but I have made other changes in my copy so you might need to play around with it.
To track how long each push takes I created a new file called connection_log.txt.
Add this to the top of deploy.php
<?php
/*
* Set the memory limit high so that we don't hit memory errors.
*/
ini_set('memory_limit', '250M');
/*
* We don't want execution errors so we will just set unlimited execution time.
*/
ini_set('max_execution_time', 0);
ob_end_clean();
ignore_user_abort(true);
set_time_limit(0);
/*
* We are going to forcefully close the connection which allows
* BitBucket/GitHub to move on and let our script run uninterrupted.
*/
header("Connection: close\r\n");
header("Content-Encoding: none\r\n");
/* Start output buffering so we can get a content size */
ob_start();
if ($fp = fopen('connection_log.txt', 'a')) {
$start_time = microtime(true);
fwrite($fp, 'A PUSH was started at ' . $start_time . "" . PHP_EOL);
}
echo "Roger that! The deployment script has received your request.";
$size = ob_get_length();
header("Content-Length: $size");
/*
* Strange behaviour, will not work
* Unless both are called !
*/
ob_end_flush();
flush();
/* Now clean out */
ob_end_clean();
Add this to the bottom of deploy.php
$end_time = microtime(true);
fwrite($fp, 'The push finally finished at ' . $end_time . "." . PHP_EOL);
fwrite($fp, 'In total it took ' . ($end_time - $start_time). " seconds." . PHP_EOL . PHP_EOL);
fclose($fp);
carlzata
Wanchai
Hi @Wanchai,
Thank you for this awesome script! It works perfectly when i try to push few files, but the webhook fails if webhook runtime is more than 10seconds which i think Bitbucket wont fix. Is there anyway we can fix these timeouts?
Thanks!