WandererXII / lishogi

☗ lishogi.org: the forever free, adless and open source shogi server forked from lichess.org ☗
https://lishogi.org
GNU Affero General Public License v3.0
272 stars 41 forks source link

Byoyomi countdown sound #181

Open justremember opened 3 years ago

justremember commented 3 years ago

I know people have brought this up in discord. Just putting this here for easier tracking.

For settings I suggest a separate category beside "Sound" and not integrating it with current sound packs, if possible. EDIT: Wanderer suggested this option be in preferences instead.

ddugovic commented 3 years ago

Well... the next question becomes what language the numbers should be counted in. Lichess has a built-in countdown for tournament starts, however Japanese counting is usually done 1 2 3 4 5 6 7 8 9.

justremember commented 3 years ago

Default sound should still be beeps, fits with lichess/lishogi's minimalist theme. I had someone record english translations of 81dojo countdown sounds, can use that. As for japanese, no one yet but we can try finding someone to do it.

justremember commented 3 years ago

Related: https://github.com/WandererXII/lishogi/issues/209

From #suggestions "Suggestion: Add more chime sounds when nearing the end of byoyomi count, i.e. every 10th second, and every second for counts in the last 10seconds"

About the last 3 seconds sound, something like this. maybe not continuous beep, but a different sound would be enough. https://www.youtube.com/watch?v=VnPRlAmnPfs

justremember commented 3 years ago

Ok I don't know when this will ever be implemented, but we can start by finding someone to record copyright-free japanese countdown sounds. @karakoro know anyone with a good voice and a very good mic?

ghost commented 3 years ago

I am personally friends with Vtubers. If you can tell me more about what kind of audio you need, I can negotiate directly with them. Of course, these are people who don't use voice changers.

justremember commented 3 years ago

@karakoro Cool, I don't know what the final format will be but let's do something like the 81dojo phrases for now. These should be in separate audio files.

ghost commented 3 years ago

There are more streamers these days, and everyone wants this feature. If it is possible, please make it a priority.

I know three Vtubers (one male, two female) who understand Shogi and specialize in voice, who can probably record the voice without any problem.

I think the format presented by justremember is fine. May I begin negotiations?

justremember commented 3 years ago

Yes please.

justremember commented 3 years ago

We have received byoyomi sound files from Chisei Mazawa, so if anyone wants to code this feature, just message me for the .mp3's. Let's try to follow the 81dojo pattern of counting, this is what every site & pro game does afaik.

https://youtu.be/Uy9Eid8267M?t=1786 skip to 29:46

Notice it counts up while the seconds count down. If the byo is at 30 seconds, it says "juubyou" (10 seconds) at 0:20, "nijuubyou" (20 seconds) at 0:10, "ichi" (1) at 0:09, "ni" (2) at 0:08, "san" (3) at 0:07, etc. until "kyuu" (9) at 0:01.

I also have english countdown voices from an anonymous source.

DiptaRising commented 4 months ago

+1

We have received byoyomi sound files from Chisei Mazawa, so if anyone wants to code this feature, just message me for the .mp3's. Let's try to follow the 81dojo pattern of counting, this is what every site & pro game does afaik.

https://youtu.be/Uy9Eid8267M?t=1786 skip to 29:46

Notice it counts up while the seconds count down. If the byo is at 30 seconds, it says "juubyou" (10 seconds) at 0:20, "nijuubyou" (20 seconds) at 0:10, "ichi" (1) at 0:09, "ni" (2) at 0:08, "san" (3) at 0:07, etc. until "kyuu" (9) at 0:01.

I also have english countdown voices from an anonymous source.

vmsimone commented 4 months ago

@justremember Would you mind sending me the mp3's? I'd like to tackle this in a fork/branch.

Thank you